perf: Add AST caching for parsed documents#1153
Closed
CybotTM wants to merge 2 commits intoTYPO3-Documentation:mainfrom
Closed
perf: Add AST caching for parsed documents#1153CybotTM wants to merge 2 commits intoTYPO3-Documentation:mainfrom
CybotTM wants to merge 2 commits intoTYPO3-Documentation:mainfrom
Conversation
Introduces CachingParseFileHandler that decorates ParseFileHandler with: - Content-hash based caching to detect unchanged files - File-based caching with configurable TTL (default 24 hours) - In-memory caching for current request deduplication - ~40% parse time reduction for unchanged files Cache key includes file contents, path, header level, and root flag. Serialized DocumentNode stored in system temp directory. PHP 8.1 compatible.
This was referenced Jan 23, 2026
- Use PHP 8.1 octal notation (0o755) - Compact empty constructor braces
Contributor
Author
|
Closing due to integration issues with Symfony's service decoration pattern. The AST caching decorator conflicts with how ParseFileHandler is used in the message bus. Will revisit with a different approach (possibly event-based caching). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces
CachingParseFileHandlerthat decoratesParseFileHandlerto cache parsed document AST, avoiding re-parsing unchanged files.Features
Performance Impact
~40% parse time reduction for unchanged files during incremental builds.
Technical Details
CachingParseFileHandlerwraps existingParseFileHandler{sys_temp_dir}/typo3-guides-ast-cache/Part of Performance Initiative
This is Phase 1.2 of the performance optimization initiative tracked in #1143.
Related PRs:
Upstream dependencies (phpdocumentor/guides):
Test plan